Feat: button block prop to make button fit container #11500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ant-design ready! Built with commit 1d1e036ceb0d924db4f9992ee0e333c4e2024e50 |
|
Deploy preview for ant-design ready! Built with commit 74ca2d9 |
|
How about |
ilanus
changed the title
block prop to make button fit container
ilanus
changed the title
block prop to make button fit container
|
Sounds good to me |
|
Please fix the ci. |
|
The branch is rebased and button tests are updated, not sure why CI is failing, I think not due to my code. |
|
ci fixed in 0156fef, try rebase feature-3.8.0 again. |
Codecov Report
@@ Coverage Diff @@
## feature-3.8.0 #11500 +/- ##
==============================================
Coverage 91.92% 91.92%
==============================================
Files 199 199
Lines 5089 5089
Branches 1416 1388 -28
==============================================
Hits 4678 4678
- Misses 405 407 +2
+ Partials 6 4 -2
Continue to review full report at Codecov.
|
|
@afc163 should be good now |
ilanus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I think it would be nice to have this prop and users will not have to specify manually style width: 100% which results in mixing css with inline styles
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master, feature for latest active branchfeature-x.x.npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
elif isNewFeature :