New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: button block prop to make button fit container #11500
Feat: button block prop to make button fit container #11500
Conversation
Deploy preview for ant-design ready! Built with commit 1d1e036ceb0d924db4f9992ee0e333c4e2024e50 |
Deploy preview for ant-design ready! Built with commit 74ca2d9 |
How about |
block
prop to make button fit container
block
prop to make button fit container
Sounds good to me |
Please fix the ci. |
The branch is rebased and button tests are updated, not sure why CI is failing, I think not due to my code. |
ci fixed in 0156fef, try rebase feature-3.8.0 again. |
Codecov Report
@@ Coverage Diff @@
## feature-3.8.0 #11500 +/- ##
==============================================
Coverage 91.92% 91.92%
==============================================
Files 199 199
Lines 5089 5089
Branches 1416 1388 -28
==============================================
Hits 4678 4678
- Misses 405 407 +2
+ Partials 6 4 -2
Continue to review full report at Codecov.
|
@afc163 should be good now |
I think it would be nice to have this prop and users will not have to specify manually style width: 100% which results in mixing css with inline styles
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master
, feature for latest active branchfeature-x.x
.npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
elif isNewFeature :