New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: button block prop to make button fit container #11500

Merged
merged 6 commits into from Jul 31, 2018

Conversation

Projects
None yet
3 participants
@ilanus
Collaborator

ilanus commented Jul 28, 2018

I think it would be nice to have this prop and users will not have to specify manually style width: 100% which results in mixing css with inline styles

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Jul 28, 2018

Deploy preview for ant-design ready!

Built with commit 1d1e036

https://deploy-preview-11500--ant-design.netlify.com

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Jul 28, 2018

Deploy preview for ant-design ready!

Built with commit 74ca2d9

https://deploy-preview-11500--ant-design.netlify.com

@afc163

This comment has been minimized.

Member

afc163 commented Jul 29, 2018

How about <Button block /> as react-bootstrap?

@ilanus ilanus changed the title from feat: button fitContainer prop to make button fit container to feat: button `block` prop to make button fit container Jul 29, 2018

@ilanus ilanus changed the title from feat: button `block` prop to make button fit container to feat: button block prop to make button fit container Jul 29, 2018

@ilanus

This comment has been minimized.

Collaborator

ilanus commented Jul 29, 2018

Sounds good to me 👍

@afc163

This comment has been minimized.

Member

afc163 commented Jul 30, 2018

Please fix the ci.

@ilanus

This comment has been minimized.

Collaborator

ilanus commented Jul 30, 2018

The branch is rebased and button tests are updated, not sure why CI is failing, I think not due to my code.

@afc163

This comment has been minimized.

Member

afc163 commented Jul 31, 2018

ci fixed in 0156fef, try rebase feature-3.8.0 again.

@codecov

This comment has been minimized.

codecov bot commented Jul 31, 2018

Codecov Report

Merging #11500 into feature-3.8.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           feature-3.8.0   #11500   +/-   ##
==============================================
  Coverage          91.92%   91.92%           
==============================================
  Files                199      199           
  Lines               5089     5089           
  Branches            1416     1388   -28     
==============================================
  Hits                4678     4678           
- Misses               405      407    +2     
+ Partials               6        4    -2
Impacted Files Coverage Δ
components/button/button.tsx 95.06% <100%> (ø) ⬆️
components/time-picker/index.tsx 74.5% <0%> (ø) ⬆️
components/transfer/index.tsx 87.41% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0156fef...74ca2d9. Read the comment docs.

@ilanus

This comment has been minimized.

Collaborator

ilanus commented Jul 31, 2018

@afc163 should be good now 😄

@afc163 afc163 merged commit d7a9783 into ant-design:feature-3.8.0 Jul 31, 2018

20 checks passed

WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 91.92%)
Details
codecov/project 91.92% (+0%) compared to 0156fef
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@ilanus ilanus changed the title from feat: button block prop to make button fit container to Feat: button block prop to make button fit container Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment