Support centered settings #11537
Merged
Support centered settings #11537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ant-design ready! Built with commit 37b8fa2 |
|
@afc163 The ci tests has failed, what did I missed? |
afc163
reviewed
Jul 31, 2018
| @@ -188,7 +194,8 @@ export default class Modal extends React.Component<ModalProps, {}> { | |||
|
|
|||
| return ( | |||
| <Dialog | |||
| {...this.props} | |||
| {...restProps} | |||
There was a problem hiding this comment.
prefixCls is missing in restProps
There was a problem hiding this comment.
Please run npm test in your local environment to make sure test is OK.
There was a problem hiding this comment.
I want to drop the centered.
afc163
reviewed
Jul 31, 2018
components/modal/Modal.tsx
Outdated
| {...this.props} | ||
| {...restProps} | ||
| prefixCls={prefixCls} | ||
| className={classNames({ [`${prefixCls}-centered`]: centered }, className)} |
afc163
reviewed
Jul 31, 2018
components/modal/confirm.tsx
Outdated
| @@ -32,6 +32,9 @@ const ConfirmDialog = (props: ConfirmDialogProps) => { | |||
| const classString = classNames( | |||
| prefixCls, | |||
| `${prefixCls}-${props.type}`, | |||
| { | |||
| [`${prefixCls}-centered`]: props.centered, | |||
Codecov Report
@@ Coverage Diff @@
## feature-3.8.0 #11537 +/- ##
=================================================
+ Coverage 91.92% 92% +0.08%
=================================================
Files 199 199
Lines 5089 5129 +40
Branches 1416 1441 +25
=================================================
+ Hits 4678 4719 +41
- Misses 405 406 +1
+ Partials 6 4 -2
Continue to review full report at Codecov.
|
yoyo837
added a commit
to yoyo837/ant-design
that referenced
this pull request
Aug 1, 2018
10 tasks
afc163
pushed a commit
that referenced
this pull request
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution! :-)
Clean #11396
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master, feature for latest active branchfeature-x.x.npm run lintand fix those errors before submitting in order to keep consistent code style.windowsExtra checklist:
if isBugFix :
elif isNewFeature :