New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strokeLinecap attribute to progress component #11547

Merged
merged 1 commit into from Aug 4, 2018

Conversation

Projects
None yet
3 participants
@blatinier
Contributor

blatinier commented Jul 31, 2018

Description:

Allow to control strokeLinecap of progress bar (square or round). round stays the default.

PR Checklist:

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist NewFeature:

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@blatinier

This comment has been minimized.

Contributor

blatinier commented Jul 31, 2018

I did not added unit tests for it since it really just CSS stuff. I regenerated jest snapshots to pass though.

Tell me if new tests are needed.

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Jul 31, 2018

Deploy preview for ant-design failed.

Built with commit a8249cd

https://app.netlify.com/sites/ant-design/deploys/5b651d8dc965924cf92eaed6

@codecov

This comment has been minimized.

codecov bot commented Aug 4, 2018

Codecov Report

Merging #11547 into feature-3.8.0 will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                @@
##           feature-3.8.0   #11547      +/-   ##
=================================================
+ Coverage          91.92%   91.95%   +0.02%     
=================================================
  Files                199      199              
  Lines               5091     5106      +15     
  Branches            1427     1436       +9     
=================================================
+ Hits                4680     4695      +15     
  Misses               407      407              
  Partials               4        4
Impacted Files Coverage Δ
components/progress/progress.tsx 97.91% <100%> (+0.09%) ⬆️
components/timeline/Timeline.tsx 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d631d...a8249cd. Read the comment docs.

@afc163 afc163 merged commit 2b72149 into ant-design:feature-3.8.0 Aug 4, 2018

19 of 20 checks passed

deploy/netlify Deploy preview failed.
Details
WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 91.92%)
Details
codecov/project 91.95% (+0.02%) compared to f4d631d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@blatinier blatinier deleted the blatinier:feature/stroke-linecap-progress branch Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment