New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal.confirm's title should use overflow:hidden to avoid scrollbar #11568

Merged
merged 1 commit into from Aug 2, 2018

Conversation

Projects
None yet
3 participants
@cheshireoctopus
Contributor

cheshireoctopus commented Aug 1, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Notes

Addresses: #11566

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Aug 1, 2018

Deploy preview for ant-design ready!

Built with commit e1a85bf

https://deploy-preview-11568--ant-design.netlify.com

@afc163 afc163 merged commit 10f1c6c into ant-design:master Aug 2, 2018

17 of 18 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@cheshireoctopus cheshireoctopus deleted the cheshireoctopus:confirm-title-overflow-hidden branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment