/ant-design

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: badge offset x y axis order error #11648

Merged
merged 1 commit into from Aug 7, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tangjinzhou @afc163 @ant-design-bot
@tangjinzhou
Contributor

tangjinzhou commented Aug 7, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

Maybe changing the documentation is more reasonable.
@afc163

This comment has been minimized.

Sign in to view
Member

afc163 commented Aug 7, 2018

oops

@afc163 afc163 merged commit 257f3ec into ant-design:master Aug 7, 2018
2 of 5 checks passed

2 of 5 checks passed

ci/circleci: setup Your tests are queued behind your running builds
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deploy/netlify Deploy preview processing.
Details
WIP ready for review
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@ant-design-bot

This comment has been minimized.

Sign in to view

ant-design-bot commented Aug 7, 2018

Deploy preview for ant-design ready!

Built with commit 2137e81

https://deploy-preview-11648--ant-design.netlify.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment