New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate lifecycle method: Upload, CheckboxGroup, Layout.Sider, Tooltip, Popconfirm #11682

Merged
merged 6 commits into from Aug 10, 2018

Conversation

Projects
None yet
3 participants
@dancerphil
Contributor

dancerphil commented Aug 9, 2018

what is done

  • replace legacy componentWillReceiveProps with static getDerivedStateFromProps

  • add test to ensure controlled component

  • peer with react@15

checklist

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

no

elif isNewFeature :

#9792

  • Add unit tests for the feature.
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Aug 9, 2018

Deploy preview for ant-design ready!

Built with commit 027500c

https://deploy-preview-11682--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented Aug 9, 2018

Codecov Report

Merging #11682 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11682      +/-   ##
==========================================
+ Coverage      92%   92.18%   +0.18%     
==========================================
  Files         200      200              
  Lines        5113     5117       +4     
  Branches     1434     1433       -1     
==========================================
+ Hits         4704     4717      +13     
+ Misses        405      396       -9     
  Partials        4        4
Impacted Files Coverage Δ
components/upload/Upload.tsx 87.61% <100%> (+2.02%) ⬆️
components/tooltip/index.tsx 92.85% <100%> (+0.17%) ⬆️
components/layout/Sider.tsx 89.53% <100%> (+1.43%) ⬆️
components/checkbox/Group.tsx 97.87% <100%> (+8.98%) ⬆️
components/upload/UploadList.tsx 89.79% <0%> (-0.41%) ⬇️
components/anchor/Anchor.tsx 90.9% <0%> (ø) ⬆️
components/affix/index.tsx 89.16% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update debee2e...027500c. Read the comment docs.

@dancerphil dancerphil changed the title from Migrate lifecycle method: Upload, CheckboxGroup, Layout.Sider, Tooltip to Migrate lifecycle method: Upload, CheckboxGroup, Layout.Sider, Tooltip, Popconfirm Aug 9, 2018

@dancerphil

This comment has been minimized.

Contributor

dancerphil commented Aug 9, 2018

Try to reproduce the Travis CI error but failed.

Passed.

@dancerphil

This comment has been minimized.

Contributor

dancerphil commented Aug 9, 2018

Ready for merge.

@dancerphil dancerphil force-pushed the dancerphil:master branch from 48ae532 to 027500c Aug 10, 2018

@yutingzhao1991 yutingzhao1991 merged commit 8a9fbcb into ant-design:master Aug 10, 2018

20 checks passed

WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92%)
Details
codecov/project 92.2% (+0.2%) compared to debee2e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@dancerphil dancerphil referenced this pull request Aug 19, 2018

Closed

Spin: lifecycle method migrate #11786

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment