move getPopupContainer from SelectProps to AbstractSelectProps #11690
Conversation
Deploy preview for ant-design ready! Built with commit 1b4c9c3 |
Codecov Report
@@ Coverage Diff @@
## master #11690 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 200 200
Lines 5109 5109
Branches 1433 1396 -37
=======================================
Hits 4702 4702
Misses 403 403
Partials 4 4
Continue to review full report at Codecov.
|
2c4c5fc
into
ant-design:master
20 checks passed
20 checks passed
security/snyk - package.json (paranoidjk)
No manifest changes detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master
, feature for latest active branchfeature-x.x
.npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :