Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move getPopupContainer from SelectProps to AbstractSelectProps #11690



Copy link

@Huanghuiying0624 Huanghuiying0624 commented Aug 9, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

Copy link

Deploy preview for ant-design ready!

Built with commit 1b4c9c3

Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #11690 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11690   +/-   ##
  Coverage   92.03%   92.03%           
  Files         200      200           
  Lines        5109     5109           
  Branches     1433     1396   -37     
  Hits         4702     4702           
  Misses        403      403           
  Partials        4        4
Impacted Files Coverage Δ
components/select/index.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f78cc9...1b4c9c3. Read the comment docs.

@afc163 afc163 merged commit 2c4c5fc into ant-design:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants