Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix(Icon) fix SVG element style #11894

Merged
merged 2 commits into from Aug 29, 2018
Merged

Conversation

HeskeyBaozi
Copy link
Contributor

@HeskeyBaozi HeskeyBaozi commented Aug 27, 2018

Merge

Already used rebase and merged from branch feature-3.9.0.

Features

  • use @ant-design/icons@~0.3.0-beta and @ant-design/icons-react@~0.3.0-beta

Bug Fixes

  • The inner SVG element is applied with display: block

    Before After
    2018-08-27 11 16 32 2018-08-27 11 17 57

Request

更新beta版本

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 27, 2018

Deploy preview for ant-design ready!

Built with commit 2e85c74

https://deploy-preview-11894--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #11894 into feature-3.9.0 will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           feature-3.9.0   #11894      +/-   ##
=================================================
+ Coverage          92.19%   92.28%   +0.09%     
=================================================
  Files                206      206              
  Lines               5395     5447      +52     
  Branches            1512     1527      +15     
=================================================
+ Hits                4974     5027      +53     
+ Misses               417      416       -1     
  Partials               4        4
Impacted Files Coverage Δ
components/modal/confirm.tsx 91.83% <0%> (-1.03%) ⬇️
components/select/index.tsx 100% <0%> (ø) ⬆️
components/upload/UploadList.tsx 90.19% <0%> (+1.96%) ⬆️
components/modal/Modal.tsx 86.95% <0%> (+7.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e31067...2e85c74. Read the comment docs.

@HeskeyBaozi HeskeyBaozi changed the title WIP: Feat(Icon) use brand new SVG icons & Hotfix(Icon) fix SVG element style Hotfix(Icon) fix SVG element style Aug 27, 2018
@chenshuai2144 chenshuai2144 merged commit c73ad80 into feature-3.9.0 Aug 29, 2018
@chenshuai2144 chenshuai2144 deleted the feature/svg-icon branch August 29, 2018 10:40
@afc163
Copy link
Member

afc163 commented Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants