New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Anchor onClick #11898

Merged
merged 10 commits into from Aug 28, 2018

Conversation

Projects
None yet
3 participants
@mushan0x0
Contributor

mushan0x0 commented Aug 27, 2018

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

mushan0x0 added some commits Aug 26, 2018

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Aug 27, 2018

Deploy preview for ant-design ready!

Built with commit 5b26077

https://deploy-preview-11898--ant-design.netlify.com

mushan0x0 added some commits Aug 27, 2018

@afc163

This comment has been minimized.

Member

afc163 commented Aug 28, 2018

ci broken

unregisterLink: (link: string) => void;
activeLink: string | null;
scrollTo: (link: string) => void;
propClick?: (e: React.MouseEvent<HTMLElement>, link: { title: React.ReactNode, href: string }) => void;

This comment has been minimized.

@afc163

afc163 Aug 28, 2018

Member

How about onClick?

This comment has been minimized.

@mushan0x0

mushan0x0 Aug 28, 2018

Contributor

我觉得可以

@codecov

This comment has been minimized.

codecov bot commented Aug 28, 2018

Codecov Report

Merging #11898 into feature-3.9.0 will increase coverage by 0.65%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                @@
##           feature-3.9.0   #11898      +/-   ##
=================================================
+ Coverage          92.19%   92.85%   +0.65%     
=================================================
  Files                206      207       +1     
  Lines               5395     5863     +468     
  Branches            1512     1694     +182     
=================================================
+ Hits                4974     5444     +470     
+ Misses               417      416       -1     
+ Partials               4        3       -1
Impacted Files Coverage Δ
components/anchor/AnchorLink.tsx 100% <100%> (ø) ⬆️
components/anchor/Anchor.tsx 90.83% <100%> (-0.08%) ⬇️
components/drawer/index.tsx 97.19% <0%> (-1.38%) ⬇️
components/modal/confirm.tsx 91.83% <0%> (-1.03%) ⬇️
components/pagination/Pagination.tsx 100% <0%> (ø) ⬆️
components/input-number/index.tsx 100% <0%> (ø) ⬆️
components/switch/index.tsx 100% <0%> (ø) ⬆️
components/icon/index.tsx 100% <0%> (ø) ⬆️
components/input/Input.tsx 100% <0%> (ø) ⬆️
components/steps/index.tsx 100% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e31067...5b26077. Read the comment docs.

@mushan0x0

This comment has been minimized.

Contributor

mushan0x0 commented Aug 28, 2018

ci又失败了,我觉得不是代码的问题

@afc163 afc163 merged commit dd37457 into ant-design:feature-3.9.0 Aug 28, 2018

20 checks passed

WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.19%)
Details
codecov/project 92.85% (+0.65%) compared to 5e31067
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details
@afc163

This comment has been minimized.

Member

afc163 commented Aug 28, 2018

ref #10577

@mushan0x0 mushan0x0 deleted the mushan0x0:anchor-onClick branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment