New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #11908 missing right input border #11965

Merged
merged 1 commit into from Aug 30, 2018

Conversation

Projects
None yet
3 participants
@hongxuWei
Contributor

hongxuWei commented Aug 30, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@hongxuWei

This comment has been minimized.

Contributor

hongxuWei commented Aug 30, 2018

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Aug 30, 2018

Deploy preview for ant-design ready!

Built with commit 5485c7c

https://deploy-preview-11965--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented Aug 30, 2018

Codecov Report

Merging #11965 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11965      +/-   ##
==========================================
+ Coverage      92%   92.04%   +0.03%     
==========================================
  Files         200      200              
  Lines        5192     5192              
  Branches     1460     1460              
==========================================
+ Hits         4777     4779       +2     
+ Misses        411      409       -2     
  Partials        4        4
Impacted Files Coverage Δ
components/upload/UploadList.tsx 90.19% <0%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 698aa3a...5485c7c. Read the comment docs.

@afc163 afc163 merged commit 278ad82 into ant-design:master Aug 30, 2018

20 checks passed

WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 698aa3a...5485c7c
Details
codecov/project 92.04% (+0.03%) compared to 698aa3a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment