Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make message icons optional #11982

Merged
merged 1 commit into from Sep 2, 2018
Merged

Conversation

hsiehjack
Copy link
Contributor

Fix #9762

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@IssueHuntBot IssueHuntBot mentioned this pull request Aug 31, 2018
1 task
@ant-design-bot
Copy link
Contributor

Deploy preview for ant-design ready!

Built with commit 268c1d3

https://deploy-preview-11982--ant-design.netlify.com

@afc163 afc163 merged commit 175ae52 into ant-design:feature-3.9.0 Sep 2, 2018
@afc163
Copy link
Member

afc163 commented Sep 2, 2018

close #11979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants