New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make message icons optional #11982

Merged
merged 1 commit into from Sep 2, 2018

Conversation

Projects
None yet
3 participants
@hsiehjack
Contributor

hsiehjack commented Aug 31, 2018

Fix #9762

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@IssuehuntBot IssuehuntBot referenced this pull request Aug 31, 2018

Closed

Make Message icons optional #9762

1 of 1 task complete
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Aug 31, 2018

Deploy preview for ant-design ready!

Built with commit 268c1d3

https://deploy-preview-11982--ant-design.netlify.com

@afc163 afc163 merged commit 175ae52 into ant-design:feature-3.9.0 Sep 2, 2018

12 of 18 checks passed

ci/circleci: test_dist Your tests failed on CircleCI
Details
ci/circleci: test_dom Your tests failed on CircleCI
Details
ci/circleci: test_es Your tests failed on CircleCI
Details
ci/circleci: test_lib Your tests failed on CircleCI
Details
ci/circleci: test_node Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@afc163

This comment has been minimized.

Member

afc163 commented Sep 2, 2018

close #11979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment