New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/iconfont no display #12013

Merged
merged 2 commits into from Sep 3, 2018

Conversation

Projects
None yet
3 participants
@HeskeyBaozi
Member

HeskeyBaozi commented Sep 3, 2018

fix warning

console.error node_modules/_warning@4.0.2@warning/warning.js:34
    Warning: Icon should have `type` prop or `component` prop or `children`.

  console.error node_modules/_warning@4.0.2@warning/warning.js:34
    Warning: Make sure that you provide correct `viewBox` prop (default `0 0 1024 1024`) to the icon.

  console.error node_modules/_@ant-design_icons-react@1.0.0@@ant-design/icons-react/lib/utils.js:39
    [@ant-design/icons-react]: Could not find icon: icon-tuichu-o.

具体表现为走createFromIconFontCN({...}) 也会创建 Icon。但是 type 属性传入 Icon 走了组件逻辑

HeskeyBaozi added some commits Sep 3, 2018

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Sep 3, 2018

Deploy preview for ant-design ready!

Built with commit b51225b

https://deploy-preview-12013--ant-design.netlify.com

@afc163 afc163 merged commit f2467a1 into master Sep 3, 2018

18 of 19 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the hotfix/iconfont-no-display branch Sep 3, 2018

@HeskeyBaozi HeskeyBaozi referenced this pull request Sep 3, 2018

Merged

changelog 3.9.1 #12038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment