New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/icon issue #12016

Merged
merged 18 commits into from Sep 3, 2018

Conversation

Projects
None yet
4 participants
@HeskeyBaozi
Member

HeskeyBaozi commented Sep 3, 2018

Before After
image image
image image
image image
image image
image image
image image
image image
image image
image image
image image

解决新旧图标同时出现的问题。e.g.
image

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Sep 3, 2018

Deploy preview for ant-design ready!

Built with commit f5cfbd6

https://deploy-preview-12016--ant-design.netlify.com

@HeskeyBaozi HeskeyBaozi changed the title from Hotfix/icon issue to WIP: Hotfix/icon issue Sep 3, 2018

@codecov

This comment has been minimized.

codecov bot commented Sep 3, 2018

Codecov Report

Merging #12016 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12016      +/-   ##
==========================================
+ Coverage   92.34%   92.38%   +0.04%     
==========================================
  Files         208      208              
  Lines        5449     5452       +3     
  Branches     1519     1532      +13     
==========================================
+ Hits         5032     5037       +5     
  Misses        411      411              
+ Partials        6        4       -2
Impacted Files Coverage Δ
components/modal/index.tsx 100% <ø> (ø) ⬆️
components/form/FormItem.tsx 98.79% <100%> (ø) ⬆️
components/time-picker/index.tsx 81.81% <100%> (ø) ⬆️
components/progress/progress.tsx 97.91% <100%> (ø) ⬆️
components/alert/index.tsx 94.11% <100%> (+0.24%) ⬆️
components/transfer/index.tsx 87.91% <0%> (ø) ⬆️
components/upload/UploadList.tsx 90.19% <0%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b0244a...f5cfbd6. Read the comment docs.

@HeskeyBaozi HeskeyBaozi changed the title from WIP: Hotfix/icon issue to Hotfix/icon issue Sep 3, 2018

@HeskeyBaozi HeskeyBaozi changed the title from Hotfix/icon issue to WIP:Hotfix/icon issue Sep 3, 2018

@HeskeyBaozi HeskeyBaozi changed the title from WIP:Hotfix/icon issue to Hotfix/icon issue Sep 3, 2018

@HeskeyBaozi HeskeyBaozi changed the title from Hotfix/icon issue to WIP: Hotfix/icon issue Sep 3, 2018

@zombieJ

This comment has been minimized.

Member

zombieJ commented Sep 3, 2018

还是 WIP?

@afc163

This comment has been minimized.

Member

afc163 commented Sep 3, 2018

Message.error 也挂了。

@HeskeyBaozi HeskeyBaozi changed the title from WIP: Hotfix/icon issue to Hotfix/icon issue Sep 3, 2018

HeskeyBaozi added some commits Sep 3, 2018

@afc163

This comment has been minimized.

Member

afc163 commented Sep 3, 2018

image

多选的勾没了。

@HeskeyBaozi

This comment has been minimized.

Member

HeskeyBaozi commented Sep 3, 2018

我知道了。这些问题实际上都是rebase的时候丢失了。😂

@zombieJ zombieJ merged commit 6702489 into master Sep 3, 2018

21 checks passed

WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.34%)
Details
codecov/project 92.38% (+0.04%) compared to 6b0244a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@zombieJ zombieJ deleted the hotfix/icon-issue branch Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment