fix:onOpenChange handler not being called in RangePicker for preset r… #12142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix lint, use |
|
Deploy preview for ant-design ready! Built with commit 55f54b4 |
|
英文有点差，可以在这里直接用中文对话吗？我有一个疑问，想请教一下。 @afc163 |
|
Rebase 一下 master 以修复 ci。 |
afc163
reviewed
Sep 8, 2018
| @@ -184,10 +184,14 @@ class RangePicker extends React.Component<any, RangePickerState> { | |||
|
|
|||
| this.setValue(value, true); | |||
|
|
|||
| const { onOk } = this.props; | |||
| const { onOk,onOpenChange } = this.props; | |||
There was a problem hiding this comment.
就是我运行lint命令，给出提示 说 strict-bound-class-methods 找不到， 然后格式化不了代码。 今天看你更新了 antd-tools
There was a problem hiding this comment.
- onOk,onOpenChange
+ onOk, onOpenChange
Codecov Report
@@ Coverage Diff @@
## master #12142 +/- ##
==========================================
+ Coverage 92.26% 92.3% +0.03%
==========================================
Files 210 210
Lines 5469 5469
Branches 1535 1535
==========================================
+ Hits 5046 5048 +2
+ Misses 419 417 -2
Partials 4 4
Continue to review full report at Codecov.
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
…anges(#11631)
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master, feature for branchfeature.npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor