Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:onOpenChange handler not being called in RangePicker for preset r… #12142

Merged
merged 5 commits into from Sep 9, 2018
Merged

fix:onOpenChange handler not being called in RangePicker for preset r… #12142

merged 5 commits into from Sep 9, 2018

Conversation

@leijingdao
Copy link
Contributor

@leijingdao leijingdao commented Sep 8, 2018

…anges(#11631)

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@afc163
Copy link
Member

@afc163 afc163 commented Sep 8, 2018

Please fix lint, use npm run lint to check your code style.

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Sep 8, 2018

Deploy preview for ant-design ready!

Built with commit 55f54b4

https://deploy-preview-12142--ant-design.netlify.com

@leijingdao
Copy link
Contributor Author

@leijingdao leijingdao commented Sep 8, 2018

英文有点差,可以在这里直接用中文对话吗?我有一个疑问,想请教一下。 @afc163

@afc163
Copy link
Member

@afc163 afc163 commented Sep 8, 2018

Rebase 一下 master 以修复 ci。

@@ -184,10 +184,14 @@ class RangePicker extends React.Component<any, RangePickerState> {

this.setValue(value, true);

const { onOk } = this.props;
const { onOk,onOpenChange } = this.props;

This comment has been minimized.

@afc163

afc163 Sep 8, 2018
Member

逗号后面应该有空格。

This comment has been minimized.

@leijingdao

leijingdao Sep 9, 2018
Author Contributor

就是我运行lint命令,给出提示 说 strict-bound-class-methods 找不到, 然后格式化不了代码。 今天看你更新了 antd-tools

This comment has been minimized.

@afc163

afc163 Sep 9, 2018
Member

- onOk,onOpenChange
+ onOk, onOpenChange
@leijingdao leijingdao closed this Sep 9, 2018
@codecov
Copy link

@codecov codecov bot commented Sep 9, 2018

Codecov Report

Merging #12142 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12142      +/-   ##
==========================================
+ Coverage   92.26%    92.3%   +0.03%     
==========================================
  Files         210      210              
  Lines        5469     5469              
  Branches     1535     1535              
==========================================
+ Hits         5046     5048       +2     
+ Misses        419      417       -2     
  Partials        4        4
Impacted Files Coverage Δ
components/message/index.tsx 93.44% <ø> (ø) ⬆️
components/upload/UploadList.tsx 90.19% <0%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f54b4...99f7305. Read the comment docs.

@leijingdao leijingdao reopened this Sep 9, 2018
@afc163 afc163 merged commit e157e31 into ant-design:master Sep 9, 2018
18 checks passed
18 checks passed
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.26%)
Details
codecov/project 92.3% (+0.03%) compared to e82d7a9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@pr-triage pr-triage bot added the PR: merged label Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants