New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:onOpenChange handler not being called in RangePicker for preset r… #12142
Conversation
Please fix lint, use |
Deploy preview for ant-design ready! Built with commit 55f54b4 |
英文有点差,可以在这里直接用中文对话吗?我有一个疑问,想请教一下。 @afc163 |
Rebase 一下 master 以修复 ci。 |
@@ -184,10 +184,14 @@ class RangePicker extends React.Component<any, RangePickerState> { | |||
|
|||
this.setValue(value, true); | |||
|
|||
const { onOk } = this.props; | |||
const { onOk,onOpenChange } = this.props; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
逗号后面应该有空格。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
就是我运行lint命令,给出提示 说 strict-bound-class-methods 找不到, 然后格式化不了代码。 今天看你更新了 antd-tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- onOk,onOpenChange
+ onOk, onOpenChange
Codecov Report
@@ Coverage Diff @@
## master #12142 +/- ##
==========================================
+ Coverage 92.26% 92.3% +0.03%
==========================================
Files 210 210
Lines 5469 5469
Branches 1535 1535
==========================================
+ Hits 5046 5048 +2
+ Misses 419 417 -2
Partials 4 4
Continue to review full report at Codecov.
|
…anges(#11631)
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master
, feature for branchfeature
.npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor