Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #12204: add parameter dontAnimate to goTo of Carousel #12205

Merged
merged 1 commit into from Sep 12, 2018
Merged

fix issue #12204: add parameter dontAnimate to goTo of Carousel #12205

merged 1 commit into from Sep 12, 2018

Conversation

fengsx
Copy link

@fengsx fengsx commented Sep 12, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@ant-design-bot
Copy link
Contributor

Deploy preview for ant-design ready!

Built with commit f625864

https://deploy-preview-12205--ant-design.netlify.com

@afc163 afc163 merged commit 91868ee into ant-design:master Sep 12, 2018
@afc163
Copy link
Member

afc163 commented Sep 12, 2018

close #12204

@ycjcl868
Copy link
Member

需要加个测试用例吗?

@afc163
Copy link
Member

afc163 commented Sep 22, 2018

不需要,react-slick 只要不是我们造成的 bug,都靠他自己的质量保证。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants