New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing argument in onChange event #12243

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
None yet
3 participants
@jardicc
Contributor

jardicc commented Sep 14, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@zombieJ zombieJ merged commit 2d415d0 into ant-design:master Sep 14, 2018

2 of 4 checks passed

ci/circleci: setup CircleCI is running your tests
Details
deploy/netlify Deploy preview processing.
Details
WIP ready for review
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Sep 14, 2018

Deploy preview for ant-design ready!

Built with commit f6004c5

https://deploy-preview-12243--ant-design.netlify.com

@jardicc jardicc deleted the jardicc:patch-1 branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment