Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Item key unspected change on List component. #12299

merged 1 commit into from Sep 19, 2018

Fixed Item key unspected change on List component. #12299

merged 1 commit into from Sep 19, 2018


Copy link

@douglasjunior douglasjunior commented Sep 18, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.
    Ps: I'm not sure how to add the tests to this case.

This PR fixed the #12298 where this List component is changing the Item key after refresh.

Before After
image image

Copy link

Deploy preview for ant-design ready!

Built with commit 7875ae8

@afc163 afc163 merged commit 03b89a1 into ant-design:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants