Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decimal separator prop #12329

Merged
merged 2 commits into from Sep 20, 2018
Merged

Add decimal separator prop #12329

merged 2 commits into from Sep 20, 2018

Conversation

amedora
Copy link
Contributor

@amedora amedora commented Sep 20, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

Resolves

See also

@ant-design-bot
Copy link
Contributor

Deploy preview for ant-design ready!

Built with commit 1eb4ecc

https://deploy-preview-12329--ant-design.netlify.com

@zombieJ zombieJ merged commit eb4e6b7 into ant-design:feature Sep 20, 2018
@amedora amedora changed the title WIP: Add decimal separator prop Add decimal separator prop Sep 28, 2018
@@ -22,6 +22,7 @@ When a numeric value needs to be provided.
| min | min value | number | -Infinity |
| parser | Specifies the value extracted from formatter | function( string): number | - |
| precision | precision of input value | number | - |
| decilamSeparator | decimal separator | string | - |
Copy link
Contributor

@monkindey monkindey Sep 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decilamSeparator ==> decimalSeparator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, yes sure.

yesmeck pushed a commit that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants