Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
amedora
added some commits
Sep 20, 2018
This comment has been minimized.
This comment has been minimized.
ant-design-bot
commented
Sep 20, 2018
|
Deploy preview for ant-design ready! Built with commit 1eb4ecc |
zombieJ
merged commit eb4e6b7
into
ant-design:feature
Sep 20, 2018
13 of 18 checks passed
ci/circleci: test_dom
Your tests failed on CircleCI
Details
ci/circleci: test_es
Your tests failed on CircleCI
Details
ci/circleci: test_lib
Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
WIP
work in progress
Details
ci/circleci: compile
Your tests passed on CircleCI!
Details
ci/circleci: dist
Your tests passed on CircleCI!
Details
ci/circleci: lint
Your tests passed on CircleCI!
Details
ci/circleci: setup
Your tests passed on CircleCI!
Details
ci/circleci: test_dist
Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15
Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15
Your tests passed on CircleCI!
Details
ci/circleci: test_es_15
Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15
Your tests passed on CircleCI!
Details
ci/circleci: test_node
Your tests passed on CircleCI!
Details
ci/circleci: test_node_15
Your tests passed on CircleCI!
Details
deploy/netlify
Deploy preview ready!
Details
security/snyk - package.json (paranoidjk)
No manifest changes detected
IssuehuntBot
referenced this pull request
Sep 20, 2018
Closed
Documentation example request for InputNumber with comma as decimal separator. #10975
amedora
changed the title from
WIP: Add decimal separator prop
to
Add decimal separator prop
Sep 28, 2018
| @@ -22,6 +22,7 @@ When a numeric value needs to be provided. | ||
| | min | min value | number | -Infinity | | ||
| | parser | Specifies the value extracted from formatter | function( string): number | - | | ||
| | precision | precision of input value | number | - | | ||
| | decilamSeparator | decimal separator | string | - | |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
added a commit
to amedora/ant-design
that referenced
this pull request
Oct 1, 2018
amedora
referenced this pull request
Oct 1, 2018
Merged
fix doc typo: decilamSeparator -> decimalSeparator #12489
added a commit
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
amedora commentedSep 20, 2018
•
edited
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master, feature for branchfeature.npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
Resolves
See also