New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decimal separator prop #12329

Merged
merged 2 commits into from Sep 20, 2018

Conversation

Projects
None yet
4 participants
@amedora
Contributor

amedora commented Sep 20, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

Resolves

See also

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Sep 20, 2018

Deploy preview for ant-design ready!

Built with commit 1eb4ecc

https://deploy-preview-12329--ant-design.netlify.com

@zombieJ zombieJ merged commit eb4e6b7 into ant-design:feature Sep 20, 2018

13 of 18 checks passed

ci/circleci: test_dom Your tests failed on CircleCI
Details
ci/circleci: test_es Your tests failed on CircleCI
Details
ci/circleci: test_lib Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
WIP work in progress
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@amedora amedora changed the title from WIP: Add decimal separator prop to Add decimal separator prop Sep 28, 2018

@@ -22,6 +22,7 @@ When a numeric value needs to be provided.
| min | min value | number | -Infinity |
| parser | Specifies the value extracted from formatter | function( string): number | - |
| precision | precision of input value | number | - |
| decilamSeparator | decimal separator | string | - |

This comment has been minimized.

@monkindey

monkindey Sep 30, 2018

Contributor

decilamSeparator ==> decimalSeparator?

This comment has been minimized.

@amedora

amedora Oct 1, 2018

Contributor

oops, yes sure.

amedora added a commit to amedora/ant-design that referenced this pull request Oct 1, 2018

yesmeck added a commit that referenced this pull request Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment