Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload add props openFileDialogOnClick #12347

Merged
merged 1 commit into from Sep 21, 2018
Merged

Upload add props openFileDialogOnClick #12347

merged 1 commit into from Sep 21, 2018

Conversation

@hengkx
Copy link
Member

@hengkx hengkx commented Sep 21, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@hengkx hengkx mentioned this pull request Sep 21, 2018
3 of 10 tasks complete
@hengkx
Copy link
Member Author

@hengkx hengkx commented Sep 21, 2018

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Sep 21, 2018

Deploy preview for ant-design ready!

Built with commit 3aceff8

https://deploy-preview-12347--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Sep 21, 2018

Codecov Report

Merging #12347 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #12347   +/-   ##
========================================
  Coverage    89.51%   89.51%           
========================================
  Files          210      210           
  Lines         5530     5530           
  Branches      1550     1589   +39     
========================================
  Hits          4950     4950           
  Misses         574      574           
  Partials         6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6299e...3aceff8. Read the comment docs.

@afc163 afc163 merged commit 0b9d00a into ant-design:feature Sep 21, 2018
20 checks passed
20 checks passed
WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 7c6299e...3aceff8
Details
codecov/project 89.51% remains the same compared to 7c6299e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details
@hengkx hengkx deleted the hengkx:feature-upload branch Sep 21, 2018
@Whoaa512 Whoaa512 mentioned this pull request Oct 4, 2018
@lomocc
Copy link

@lomocc lomocc commented Oct 19, 2018

Upload 组件被包含在 <label> 中时,也需要设置 openFileDialogOnClick=false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants