New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openKeys should have higher priority #12361

Merged
merged 2 commits into from Sep 22, 2018

Conversation

Projects
None yet
3 participants
@tangjinzhou
Contributor

tangjinzhou commented Sep 21, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Sep 21, 2018

Deploy preview for ant-design ready!

Built with commit 7ed14f1

https://deploy-preview-12361--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented Sep 21, 2018

Codecov Report

Merging #12361 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12361   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files         210      210           
  Lines        5483     5483           
  Branches     1543     1543           
=======================================
  Hits         5059     5059           
  Misses        420      420           
  Partials        4        4
Impacted Files Coverage Δ
components/menu/index.tsx 97.22% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f55ee4...7ed14f1. Read the comment docs.

@afc163 afc163 merged commit 9630dc4 into ant-design:master Sep 22, 2018

19 checks passed

ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.26%)
Details
codecov/project 92.26% (+0%) compared to 1f55ee4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 referenced this pull request Sep 22, 2018

Merged

Release 3.9.3 #12364

@tangjinzhou tangjinzhou deleted the tangjinzhou:patch-1 branch Sep 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment