New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: Add the update function type definition #12370

Merged
merged 1 commit into from Sep 23, 2018

Conversation

Projects
None yet
3 participants
@adamburgess
Contributor

adamburgess commented Sep 22, 2018

#11884 added the update function: https://github.com/ant-design/ant-design/blame/46f1d3e97952e216e60ab7c737956bc3db8d9725/components/modal/confirm.tsx#L98

But it wasn't added to the ModalFunc type, so TypeScript wouldn't let me use it. This PR adds the method to that type.

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Sep 22, 2018

Deploy preview for ant-design ready!

Built with commit ec1bd31

https://deploy-preview-12370--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented Sep 22, 2018

Codecov Report

Merging #12370 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12370      +/-   ##
==========================================
- Coverage    92.3%   92.26%   -0.04%     
==========================================
  Files         210      210              
  Lines        5483     5483              
  Branches     1543     1543              
==========================================
- Hits         5061     5059       -2     
  Misses        418      418              
- Partials        4        6       +2
Impacted Files Coverage Δ
components/modal/Modal.tsx 79.31% <ø> (ø) ⬆️
components/upload/UploadList.tsx 88.46% <0%> (-1.93%) ⬇️
components/transfer/index.tsx 87.91% <0%> (ø) ⬆️
components/time-picker/index.tsx 81.81% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f1d3e...ec1bd31. Read the comment docs.

@afc163 afc163 merged commit 9b01ec1 into ant-design:master Sep 23, 2018

19 of 20 checks passed

codecov/project 92.26% (-0.04%) compared to 46f1d3e
Details
WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 46f1d3e...ec1bd31
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment