New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filterIcon type #12374

Merged
merged 1 commit into from Sep 23, 2018

Conversation

Projects
None yet
3 participants
@xiaoyu-tamu
Contributor

xiaoyu-tamu commented Sep 23, 2018

based on api [ReactNode|(filtered: boolean) => ReactNode]

https://ant.design/components/table-cn/#components-table-demo-dynamic-settings

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • [x ] Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • [x ] Make sure that you follow antd's code convention.
  • [x ] Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • [x ] Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
fix filterIcon type
based on api [ReactNode|(filtered: boolean) => ReactNode]

https://ant.design/components/table-cn/#components-table-demo-dynamic-settings
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Sep 23, 2018

Deploy preview for ant-design ready!

Built with commit 1f8ac3f

https://deploy-preview-12374--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented Sep 23, 2018

Codecov Report

Merging #12374 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12374   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files         210      210           
  Lines        5483     5483           
  Branches     1543     1543           
=======================================
  Hits         5059     5059           
- Misses        418      420    +2     
+ Partials        6        4    -2
Impacted Files Coverage Δ
components/transfer/index.tsx 87.91% <0%> (ø) ⬆️
components/time-picker/index.tsx 81.81% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38cb9d0...1f8ac3f. Read the comment docs.

@ycjcl868 ycjcl868 merged commit 2a84b40 into ant-design:master Sep 23, 2018

20 checks passed

WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 38cb9d0...1f8ac3f
Details
codecov/project 92.26% remains the same compared to 38cb9d0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment