New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #12395. input group hover style error #12407

Merged
merged 5 commits into from Sep 30, 2018

Conversation

Projects
None yet
4 participants
@hengkx
Contributor

hengkx commented Sep 26, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@hengkx

This comment has been minimized.

Contributor

hengkx commented Sep 26, 2018

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Sep 26, 2018

Deploy preview for ant-design ready!

Built with commit 67e6a8f

https://deploy-preview-12407--ant-design.netlify.com

@hengkx

This comment has been minimized.

Contributor

hengkx commented Sep 26, 2018

qq20180926-114807

@codecov

This comment has been minimized.

codecov bot commented Sep 26, 2018

Codecov Report

Merging #12407 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12407      +/-   ##
==========================================
+ Coverage   92.27%    92.3%   +0.03%     
==========================================
  Files         210      210              
  Lines        5486     5486              
  Branches     1506     1545      +39     
==========================================
+ Hits         5062     5064       +2     
+ Misses        420      418       -2     
  Partials        4        4
Impacted Files Coverage Δ
components/upload/UploadList.tsx 90.38% <0%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdaf422...67e6a8f. Read the comment docs.

&-addon,
&-wrap,
> .@{inputClass} {

This comment has been minimized.

@zombieJ

zombieJ Sep 26, 2018

Member

unnecessary empty line

This comment has been minimized.

@hengkx

hengkx Sep 26, 2018

Contributor

removed

@IssuehuntBot IssuehuntBot referenced this pull request Sep 26, 2018

Closed

输入框组合 hover 时界面抖动 #12395

0 of 1 task complete
@@ -26,7 +26,7 @@
// == when hoverd
.hover(@color: @input-hover-border-color) {
border-color: ~`colorPalette("@{color}", 5)`;
border-color: ~`colorPalette("@{color}", 5)` !important;

This comment has been minimized.

@zombieJ

zombieJ Sep 26, 2018

Member

可否尽量不用 important?

@zombieJ

This comment has been minimized.

Member

zombieJ commented Sep 26, 2018

2018-09-26 4 21 48

@hengkx

This comment has been minimized.

Contributor

hengkx commented Sep 26, 2018

image

@zombieJ

This comment has been minimized.

Member

zombieJ commented Sep 26, 2018

Seems hover has some issue:
kapture 2018-09-26 at 17 58 42

@hengkx

This comment has been minimized.

Contributor

hengkx commented Sep 26, 2018

@zombieJ 这个我看了 是因为Cascader 里面 ant-cascader-picker-label 影响的, 可以 pointer-events: none; 来解决,但是只兼容IE11,
image
image
我有个疑问,选中的值 为什么 不用input 直接显示 而需要另外用span来显示。我不清楚,这样有没有其它用意。
image

image

有什么好的建议吗?

@hengkx

This comment has been minimized.

Contributor

hengkx commented Sep 26, 2018

190217
这个gif工具 不太 好用。改了下Cascader input style,直接使用Cascader也是存在问题的

@zombieJ

This comment has been minimized.

Member

zombieJ commented Sep 26, 2018

印象里用 span 代替 input 展示是因为旧版 IE 有 bug,具体的记不清了。
我这边看应该没什么问题。@afc163 @yesmeck, double confirm?

@yesmeck yesmeck merged commit ff4d803 into ant-design:master Sep 30, 2018

20 checks passed

WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing bdaf422...67e6a8f
Details
codecov/project 92.3% (+0.03%) compared to bdaf422
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

vsoren added a commit to vsoren/ant-design that referenced this pull request Oct 5, 2018

fix ant-design#12395. input group hover style error (ant-design#12407)
First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

* [x] Make sure that you propose PR to right branch: bugfix for `master`, feature for branch `feature`.
* [x] Make sure that you follow antd's [code convention](https://github.com/ant-design/ant-design/wiki/Code-convention-for-antd).
* [x] Run `npm run lint` and fix those errors before submitting in order to keep consistent code style.
* [x] Rebase before creating a PR to keep commit history clear.
* [x] Add some descriptions and refer relative issues for you PR.

Extra checklist:

**if** *isBugFix* **:**

  * [x] Make sure that you add at least one unit test for the bug which you had fixed.

**elif** *isNewFeature* **:**

  * [ ] Update API docs for the component.
  * [ ] Update/Add demo to demonstrate new feature.
  * [ ] Update TypeScript definition for the component.
  * [ ] Add unit tests for the feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment