New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed]button can also trigger the click event when loading is true #12466

Merged
merged 1 commit into from Sep 29, 2018

Conversation

Projects
None yet
3 participants
@120216220
Contributor

120216220 commented Sep 29, 2018

IE9 does not support pointer-events

fixed button can also trigger the click event when loading is true in IE9


First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Sep 29, 2018

Deploy preview for ant-design ready!

Built with commit 2a1ce6d

https://deploy-preview-12466--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented Sep 29, 2018

Codecov Report

Merging #12466 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12466      +/-   ##
==========================================
- Coverage   92.27%   92.25%   -0.02%     
==========================================
  Files         210      210              
  Lines        5487     5490       +3     
  Branches     1546     1547       +1     
==========================================
+ Hits         5063     5065       +2     
- Misses        420      421       +1     
  Partials        4        4
Impacted Files Coverage Δ
components/button/button.tsx 93.9% <66.66%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6453ab...2a1ce6d. Read the comment docs.

@zombieJ zombieJ merged commit 6b22ae3 into ant-design:master Sep 29, 2018

18 of 20 checks passed

codecov/patch 66.66% of diff hit (target 92.27%)
Details
codecov/project 92.25% (-0.02%) compared to a6453ab
Details
WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@zombieJ

This comment has been minimized.

Member

zombieJ commented Sep 29, 2018

Thanks for contribution. Code merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment