New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #11312: add autoClearSearchValue to AbstractSelectProps #12473

Merged
merged 2 commits into from Sep 30, 2018

Conversation

Projects
None yet
3 participants
@zetamorph
Contributor

zetamorph commented Sep 29, 2018

  • extends the interface with an optional prop that can be provided to the RcSelect

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • [ x ] Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • [ x ] Make sure that you follow antd's code convention.
  • [ x ] Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • [ x ] Rebase before creating a PR to keep commit history clear.
  • [ x ] Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This fix is related to Issue #11312 and adds the optional autoClearSearchValue prop which can be supplied to RcSelect to the Select´s props. This is not really a new feature and a relatively unsubstantial one a that, so I didn´t add a demo for it, but I could do so if that´s desirable.

I updated the English API docs, but I´m not a Chinese speaker so there is no addition to the Chinese documentation. Maybe someone speaking Chinese would be willing to help out.

Johannes Löwe
fix #11312: add autoClearSearchValue to AbstractSelectProps
- extends the interface with an optional prop that can be provided to the RcSelect
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Sep 29, 2018

Deploy preview for ant-design failed.

Built with commit 4c73ca3

https://app.netlify.com/sites/ant-design/deploys/5bb07540b13fb1536395d016

@codecov

This comment has been minimized.

codecov bot commented Sep 29, 2018

Codecov Report

Merging #12473 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12473   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files         210      210           
  Lines        5492     5492           
  Branches     1548     1548           
=======================================
  Hits         5067     5067           
+ Misses        421      419    -2     
- Partials        4        6    +2
Impacted Files Coverage Δ
components/select/index.tsx 100% <ø> (ø) ⬆️
components/transfer/index.tsx 87.91% <0%> (ø) ⬆️
components/time-picker/index.tsx 81.81% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1288b1c...4c73ca3. Read the comment docs.

@IssuehuntBot IssuehuntBot referenced this pull request Sep 29, 2018

Closed

Add autoClearSearchValue to <Select> #11312

0 of 1 task complete

@yesmeck yesmeck merged commit 0126c63 into ant-design:master Sep 30, 2018

2 of 4 checks passed

deploy/netlify Deploy preview failed.
Details
ci/circleci: setup Your tests are queued behind your running builds
Details
WIP ready for review
Details
security/snyk - package.json (paranoidjk) No new issues
Details

vsoren added a commit to vsoren/ant-design that referenced this pull request Oct 5, 2018

fix ant-design#11312: add autoClearSearchValue to AbstractSelectProps (
…ant-design#12473)

- extends the interface with an optional prop that can be provided to the RcSelect

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

* [ x ] Make sure that you propose PR to right branch: bugfix for `master`, feature for branch `feature`.
* [ x ] Make sure that you follow antd's [code convention](https://github.com/ant-design/ant-design/wiki/Code-convention-for-antd).
* [ x ] Run `npm run lint` and fix those errors before submitting in order to keep consistent code style.
* [ x ] Rebase before creating a PR to keep commit history clear.
* [ x ] Add some descriptions and refer relative issues for you PR.

Extra checklist:

**if** *isBugFix* **:**

  * [ ] Make sure that you add at least one unit test for the bug which you had fixed.

**elif** *isNewFeature* **:**

  * [ ] Update API docs for the component.
  * [ ] Update/Add demo to demonstrate new feature.
  * [ ] Update TypeScript definition for the component.
  * [ ] Add unit tests for the feature.

This fix is related to Issue ant-design#11312 and adds the optional `autoClearSearchValue` prop which can be supplied to `RcSelect` to the Select´s props. This is not really a new feature and a relatively unsubstantial one a that, so I didn´t add a demo for it, but I could do so if that´s desirable.

I updated the English API docs, but I´m not a Chinese speaker so there is no addition to the Chinese documentation. Maybe someone speaking Chinese would be willing to help out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment