[bugfix] change function overload order in Form typescript define #12538
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12538 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 211 211
Lines 5542 5542
Branches 1599 1599
=======================================
Hits 5117 5117
- Misses 419 421 +2
+ Partials 6 4 -2
Continue to review full report at Codecov.
|
4d48641
into
ant-design:master
18 checks passed
18 checks passed
security/snyk - package.json (paranoidjk)
No manifest changes detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When I use with
Form.create()()
andthis.props.form.validateFields
withasync/await
in typescript:tslint always tell me:
[ts] Parameter 'errors' implicitly has an 'any' type.
In typescript,
async/await
callback will conform these after typescript overload define:The
async/await
func should use callback define firstly. Just like the above define inForm.d.ts
:So I change the order of the function overload define.