New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add limitation on checking labelPlacement #12575

Merged
merged 3 commits into from Oct 10, 2018

Conversation

Projects
None yet
2 participants
@yueyes
Contributor

yueyes commented Oct 10, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@yueyes

This comment has been minimized.

Contributor

yueyes commented on 68c3a24 Oct 10, 2018

missing type checking of labelPlacement

yueyes added some commits Oct 10, 2018

@afc163 afc163 merged commit ec9f8ab into ant-design:master Oct 10, 2018

10 of 17 checks passed

ci/circleci: test_dom Your tests failed on CircleCI
Details
ci/circleci: test_dom_15 Your tests failed on CircleCI
Details
ci/circleci: test_lib Your tests failed on CircleCI
Details
ci/circleci: test_es CircleCI is running your tests
Details
ci/circleci: test_es_15 CircleCI is running your tests
Details
ci/circleci: test_lib_15 CircleCI is running your tests
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 referenced this pull request Oct 12, 2018

Merged

Add changelog of 3.10.1 #12615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment