New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: round progress support strokeColor #12587

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
3 participants
@lyhper
Contributor

lyhper commented Oct 10, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@afc163

This comment has been minimized.

Member

afc163 commented Oct 12, 2018

Could you rebase master and make sure ci successed?

@lyhper lyhper force-pushed the lyhper:fix-progress-color branch from 00f9793 to 6930e49 Oct 12, 2018

@codecov

This comment has been minimized.

codecov bot commented Oct 12, 2018

Codecov Report

Merging #12587 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12587      +/-   ##
==========================================
+ Coverage   92.34%   92.34%   +<.01%     
==========================================
  Files         211      211              
  Lines        5549     5550       +1     
  Branches     1599     1589      -10     
==========================================
+ Hits         5124     5125       +1     
  Misses        419      419              
  Partials        6        6
Impacted Files Coverage Δ
components/progress/progress.tsx 98% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6767bcf...6930e49. Read the comment docs.

@lyhper

This comment has been minimized.

Contributor

lyhper commented Oct 12, 2018

done @afc163

@afc163 afc163 merged commit aa520f7 into ant-design:master Oct 12, 2018

18 checks passed

WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.34%)
Details
codecov/project 92.34% (+<.01%) compared to 6767bcf
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@chaserstrong

This comment has been minimized.

chaserstrong commented Oct 21, 2018

in 3.10.1, it hasn't been fixed i think...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment