New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TreeSelect type #12648

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
2 participants
@decadef20
Contributor

decadef20 commented Oct 15, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

TreeSelect added two props but lack of typing.

@decadef20 decadef20 force-pushed the decadef20:add-TreeSelect-type branch from 5e55a09 to cbe01ef Oct 15, 2018

@codecov

This comment has been minimized.

codecov bot commented Oct 15, 2018

Codecov Report

Merging #12648 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12648   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files         211      211           
  Lines        5550     5550           
  Branches     1589     1600   +11     
=======================================
  Hits         5125     5125           
  Misses        419      419           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 014b23f...cbe01ef. Read the comment docs.

@afc163 afc163 merged commit 4d42f75 into ant-design:master Oct 15, 2018

18 checks passed

WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 014b23f...cbe01ef
Details
codecov/project 92.34% remains the same compared to 014b23f
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@decadef20 decadef20 deleted the decadef20:add-TreeSelect-type branch Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment