Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VN locale for date picker component #12656

Merged
merged 1 commit into from Oct 16, 2018
Merged

Add VN locale for date picker component #12656

merged 1 commit into from Oct 16, 2018

Conversation

hieuhlc
Copy link

@hieuhlc hieuhlc commented Oct 15, 2018

This PR will fix locale VN for date picker component

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@codecov
Copy link

codecov bot commented Oct 15, 2018

Codecov Report

Merging #12656 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12656   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files         211      211           
  Lines        5550     5550           
  Branches     1561     1600   +39     
=======================================
  Hits         5125     5125           
  Misses        421      421           
  Partials        4        4
Impacted Files Coverage Δ
components/date-picker/locale/vi_VN.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d42f75...6fa9597. Read the comment docs.

@afc163 afc163 merged commit ea25889 into ant-design:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants