New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Edge ignoring pointer-events:none on button's span #12712

Merged
merged 1 commit into from Oct 19, 2018

Conversation

Projects
None yet
2 participants
@dazbo
Contributor

dazbo commented Oct 18, 2018

Fix for #12698

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

No test added, I don't know how to test that change.
Change was tested on my computer with the following browsers:

  • Chrome 70.0.3538.67
  • Firefox 62.0.3 ESR
  • IE 11.0.9600.19155

Would be nice, if some people could test/validate that change with Windows 10 and Edge to be sure there is no regression - I don't have the opportunity to access that kind of setup.

@codecov

This comment has been minimized.

codecov bot commented Oct 18, 2018

Codecov Report

Merging #12712 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12712   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files         211      211           
  Lines        5550     5550           
  Branches     1600     1561   -39     
=======================================
  Hits         5125     5125           
  Misses        421      421           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b92d4ed...03faeb8. Read the comment docs.

@dazbo dazbo referenced this pull request Oct 18, 2018

Closed

Button: inner span can raise onclick on Edge #12698

1 of 1 task complete

@yesmeck yesmeck merged commit f24917b into ant-design:master Oct 19, 2018

18 checks passed

WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing b92d4ed...03faeb8
Details
codecov/project 92.34% remains the same compared to b92d4ed
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@dazbo dazbo deleted the dazbo:fix-pointerevents-on-edge branch Oct 19, 2018

ilanus added a commit to ilanus/ant-design that referenced this pull request Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment