Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve getScroll #12784

merged 1 commit into from Oct 23, 2018

Improve getScroll #12784

merged 1 commit into from Oct 23, 2018


Copy link

@ztplz ztplz commented Oct 23, 2018

The parameter target is marked as any, which is not type-safety. So we should replace it with a more precise type. Use HTMLElement | Window | null instend of any.

Copy link

netlify bot commented Oct 23, 2018

Deploy preview for ant-design ready!

Built with commit 01a1b7d

Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #12784 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12784   +/-   ##
  Coverage   92.35%   92.35%           
  Files         211      211           
  Lines        5557     5557           
  Branches     1563     1563           
  Hits         5132     5132           
  Misses        421      421           
  Partials        4        4
Impacted Files Coverage Δ
components/_util/getScroll.tsx 80% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f8525...01a1b7d. Read the comment docs.

@afc163 afc163 merged commit 1fedef3 into ant-design:master Oct 23, 2018
@ztplz ztplz deleted the _improve branch October 23, 2018 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants