Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #12758 multiple Select drop-down bug when set dropdownMatchSelectWidth #12816

Merged
merged 3 commits into from Oct 24, 2018
Merged

fix #12758 multiple Select drop-down bug when set dropdownMatchSelectWidth #12816

merged 3 commits into from Oct 24, 2018

Conversation

@hengkx
Copy link
Member

@hengkx hengkx commented Oct 24, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@hengkx
Copy link
Member Author

@hengkx hengkx commented Oct 24, 2018

ref #12758
image

@netlify
Copy link

@netlify netlify bot commented Oct 24, 2018

Deploy preview for ant-design ready!

Built with commit ed7d89e

https://deploy-preview-12816--ant-design.netlify.com

<Option value="Yiminghe">yiminghe</Option>
<Option value="lucy">Lucy</Option>
</Select>
</div>,

This comment has been minimized.

@afc163

afc163 Oct 24, 2018
Member

No need to change demo~

This comment has been minimized.

@hengkx

hengkx Oct 24, 2018
Author Member

removed

hengkx added 2 commits Oct 24, 2018
@afc163 afc163 merged commit e1db20c into ant-design:master Oct 24, 2018
16 of 21 checks passed
16 of 21 checks passed
ci/circleci: test_dist Your tests failed on CircleCI
Details
ci/circleci: test_dom Your tests failed on CircleCI
Details
ci/circleci: test_es Your tests failed on CircleCI
Details
ci/circleci: test_lib Your tests failed on CircleCI
Details
ci/circleci: test_node Your tests failed on CircleCI
Details
Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@hengkx hengkx deleted the hengkx:fix-12758 branch Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants