New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update select props :onPopupScroll #12913

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
3 participants
@sysuzero
Contributor

sysuzero commented Nov 1, 2018

update select props type:onPopupScroll

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
update select props :onPopupScroll
update select props type:onPopupScroll
@netlify

This comment has been minimized.

netlify bot commented Nov 1, 2018

Deploy preview for ant-design ready!

Built with commit f545b9a

https://deploy-preview-12913--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented Nov 1, 2018

Codecov Report

Merging #12913 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12913   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         211      211           
  Lines        5561     5561           
  Branches     1595     1606   +11     
=======================================
  Hits         5137     5137           
  Misses        418      418           
  Partials        6        6
Impacted Files Coverage Δ
components/select/index.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b30ba95...f545b9a. Read the comment docs.

@afc163 afc163 merged commit bbd9556 into ant-design:master Nov 1, 2018

18 checks passed

ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing b30ba95...f545b9a
Details
codecov/project 92.37% remains the same compared to b30ba95
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@@ -55,7 +55,7 @@ export interface SelectProps extends AbstractSelectProps {
onDeselect?: (value: SelectValue) => any;
onBlur?: (value: SelectValue) => void;
onFocus?: () => void;
onPopupScroll?: () => any;
onPopupScroll?: (e: React.KeyboardEvent<HTMLInputElement>) => any;

This comment has been minimized.

@zombieJ

zombieJ Nov 1, 2018

Member

React.UIEventHandler<HTMLDivElement>

zombieJ added a commit that referenced this pull request Nov 2, 2018

@zombieJ zombieJ referenced this pull request Nov 3, 2018

Merged

docs: update changlog #12944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment