New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add title support in menu item #12952

Merged
merged 6 commits into from Nov 20, 2018

Conversation

Projects
None yet
3 participants
@zombieJ
Member

zombieJ commented Nov 4, 2018

Add title prop for Menu.Item to support customize title for the collapsed status.

ref #11584


Update snapshot:
kapture 2018-11-05 at 14 05 26

@zombieJ zombieJ requested review from yesmeck and afc163 Nov 4, 2018

@netlify

This comment has been minimized.

netlify bot commented Nov 4, 2018

Deploy preview for ant-design ready!

Built with commit 34d3091

https://deploy-preview-12952--ant-design.netlify.com

@afc163

This comment has been minimized.

Member

afc163 commented Nov 4, 2018

原来的 title 好像就有用,设置原生的 tooltip 用。

@zombieJ zombieJ force-pushed the menu_title branch from 79f8775 to 52d2446 Nov 5, 2018

@codecov

This comment has been minimized.

codecov bot commented Nov 5, 2018

Codecov Report

Merging #12952 into feature will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #12952      +/-   ##
===========================================
+ Coverage    92.49%   92.57%   +0.07%     
===========================================
  Files          221      221              
  Lines         5744     5747       +3     
  Branches      1666     1668       +2     
===========================================
+ Hits          5313     5320       +7     
+ Misses         426      422       -4     
  Partials         5        5
Impacted Files Coverage Δ
components/menu/MenuItem.tsx 93.33% <100%> (+1.66%) ⬆️
components/upload/UploadList.tsx 89.62% <0%> (+1.88%) ⬆️
components/tooltip/index.tsx 96.15% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28b7a7...34d3091. Read the comment docs.

@zombieJ

This comment has been minimized.

Member

zombieJ commented Nov 5, 2018

嗯,这边复用了一下。

@@ -55,6 +55,7 @@ More layouts with navigation: [layout](/components/layout).
| ----- | ----------- | ---- | ------------- |
| disabled | whether menu item is disabled or not | boolean | false |
| key | unique id of the menu item | string | |
| title | set display title for collaped item | string | |

This comment has been minimized.

@picodoth

picodoth Nov 7, 2018

Contributor

collaped => collapsed

@afc163 afc163 merged commit d366886 into feature Nov 20, 2018

18 checks passed

ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.49%)
Details
codecov/project 92.57% (+0.07%) compared to b28b7a7
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the menu_title branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment