Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
zombieJ
requested review from
yesmeck and
afc163
Nov 4, 2018
This comment has been minimized.
This comment has been minimized.
netlify
bot
commented
Nov 4, 2018
•
|
Deploy preview for ant-design ready! Built with commit 34d3091 |
This comment has been minimized.
This comment has been minimized.
|
原来的 title 好像就有用，设置原生的 tooltip 用。 |
zombieJ
added some commits
Nov 4, 2018
zombieJ
force-pushed the
menu_title
branch
from
79f8775
to
52d2446
Nov 5, 2018
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Nov 5, 2018
•
Codecov Report
@@ Coverage Diff @@
## feature #12952 +/- ##
===========================================
+ Coverage 92.49% 92.57% +0.07%
===========================================
Files 221 221
Lines 5744 5747 +3
Branches 1666 1668 +2
===========================================
+ Hits 5313 5320 +7
+ Misses 426 422 -4
Partials 5 5
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
嗯，这边复用了一下。 |
components/menu/index.en-US.md
Outdated
| @@ -55,6 +55,7 @@ More layouts with navigation: [layout](/components/layout). | ||
| | ----- | ----------- | ---- | ------------- | | ||
| | disabled | whether menu item is disabled or not | boolean | false | | ||
| | key | unique id of the menu item | string | | | ||
| | title | set display title for collaped item | string | | |
This comment has been minimized.
This comment has been minimized.
zombieJ
added some commits
Nov 7, 2018
afc163
merged commit d366886
into
feature
Nov 20, 2018
18 checks passed
ci/circleci: compile
Your tests passed on CircleCI!
Details
ci/circleci: dist
Your tests passed on CircleCI!
Details
ci/circleci: lint
Your tests passed on CircleCI!
Details
ci/circleci: setup
Your tests passed on CircleCI!
Details
ci/circleci: test_dist
Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15
Your tests passed on CircleCI!
Details
ci/circleci: test_dom
Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15
Your tests passed on CircleCI!
Details
ci/circleci: test_es
Your tests passed on CircleCI!
Details
ci/circleci: test_es_15
Your tests passed on CircleCI!
Details
ci/circleci: test_lib
Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15
Your tests passed on CircleCI!
Details
ci/circleci: test_node
Your tests passed on CircleCI!
Details
ci/circleci: test_node_15
Your tests passed on CircleCI!
Details
codecov/patch
100% of diff hit (target 92.49%)
Details
codecov/project
92.57% (+0.07%) compared to b28b7a7
Details
deploy/netlify
Deploy preview ready!
Details
security/snyk - package.json (paranoidjk)
No manifest changes detected
afc163
deleted the
menu_title
branch
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
zombieJ commentedNov 4, 2018
•
edited
Add
titleprop for Menu.Item to support customize title for the collapsed status.ref #11584
Update snapshot:
