New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(select): customize remove/clear/menuItemSelected icons #12958
Conversation
Deploy preview for ant-design ready! Built with commit 6fa4e57 |
Codecov Report
@@ Coverage Diff @@
## feature #12958 +/- ##
===========================================
- Coverage 91.85% 91.69% -0.16%
===========================================
Files 218 218
Lines 5683 5696 +13
Branches 1599 1644 +45
===========================================
+ Hits 5220 5223 +3
- Misses 458 466 +8
- Partials 5 7 +2
Continue to review full report at Codecov.
|
Pls help to update related docs. |
639f798
to
49531e5
Compare
ci broken, please rebase master to fix it. |
master rebased. |
Hi, @afc163
That's what I run. Let's make it clear. Do you mean rebase feature branch instead of master? |
Sorry, you should rebase feature branch. It is my mistake of the comment above. |
I rebased the latest feature branch, but still ci broken. After checking the ci logs, some doesn't come from my code. But I do change the select dom structure, and new select demo snapshots have been updated now. |
Rebase again, fixed it right now. |
update: |
Rebase again 😆 |
rebased, some lint errors 😕 |
Rebase again 😆... |
sth changed in |
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master
, feature for branchfeature
.npm run lint
and fix those errors before submitting in order to keep consistent code style.Related Issue: #12954
Extra checklist:
if isBugFix :
elif isNewFeature :