Skip to content

/ ant-design

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Hungarian localisations support #13026

Merged
merged 2 commits into from Nov 9, 2018
Merged

Feature: Hungarian localisations support #13026

merged 2 commits into from Nov 9, 2018

Conversation

@ilanus
Copy link
Contributor

@ilanus ilanus commented Nov 8, 2018

  • rc-calendar/lib/locale/hu_HU
  • rc-pagination/lib/locale/hu_HU
  • components/calendar/locale/hu_HU.tsx
  • components/date-picker/locale/hu_HU.tsx
  • components/locale-provider/hu_HU.tsx
  • components/time-picker/locale/hu_HU.tsx
@ilanus ilanus requested a review from afc163 Nov 8, 2018
@netlify
Copy link

@netlify netlify bot commented Nov 8, 2018

Deploy preview for ant-design ready!

Built with commit e7d3f20b3607e19e0f2554ef3729e76c7d573d22

https://deploy-preview-13026--ant-design.netlify.com
@codecov
Copy link

@codecov codecov bot commented Nov 8, 2018 •
edited

Codecov Report

Merging #13026 into feature will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #13026      +/-   ##
===========================================
- Coverage    91.88%   91.84%   -0.04%     
===========================================
  Files          216      218       +2     
  Lines         5678     5680       +2     
  Branches      1638     1628      -10     
===========================================
  Hits          5217     5217              
- Misses         454      456       +2     
  Partials         7        7
Impacted Files Coverage Δ
components/time-picker/locale/hu_HU.tsx 100% <100%> (ø)
components/date-picker/locale/hu_HU.tsx 100% <100%> (ø)
components/upload/UploadList.tsx 87.73% <0%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 713b363...48b2c8b. Read the comment docs.
@netlify
Copy link

@netlify netlify bot commented Nov 8, 2018 •
edited

Deploy preview for ant-design ready!

Built with commit 48b2c8b

https://deploy-preview-13026--ant-design.netlify.com
@afc163
Copy link
Member

@afc163 afc163 commented Nov 8, 2018

feature branch would be nicer.
@ilanus ilanus force-pushed the ilanus:feat/hu-HU-locale branch Nov 8, 2018
@ilanus ilanus changed the base branch from master to feature Nov 8, 2018
@ilanus ilanus closed this Nov 8, 2018
@ilanus ilanus force-pushed the ilanus:feat/hu-HU-locale branch to bc380a7 Nov 8, 2018
@ilanus ilanus reopened this Nov 8, 2018
@ilanus
Copy link
Contributor Author

@ilanus ilanus commented Nov 8, 2018

feature branch would be nicer.

done
@afc163
Copy link
Member

@afc163 afc163 commented Nov 9, 2018

ci broken, rebase feature to fixed it.
@afc163
Copy link
Member

@afc163 afc163 commented Nov 9, 2018

Add test case and doc like this 4d06e4d
@ilanus ilanus force-pushed the ilanus:feat/hu-HU-locale branch Nov 9, 2018
@ilanus
Copy link
Contributor Author

@ilanus ilanus commented Nov 9, 2018

Rebased, added tests. CI broken
@afc163
Copy link
Member

@afc163 afc163 commented Nov 9, 2018 •
edited

Rebase again 😆
@ilanus ilanus force-pushed the ilanus:feat/hu-HU-locale branch Nov 9, 2018
ilanus added 2 commits Nov 8, 2018
@ilanus
🌐 adding hungarian localisations
3b21911
@ilanus
✅ sort locales asc and add locale huHU tests
Loading status checks…
48b2c8b
@ilanus ilanus force-pushed the ilanus:feat/hu-HU-locale branch to 48b2c8b Nov 9, 2018
@ilanus
Copy link
Contributor Author

@ilanus ilanus commented Nov 9, 2018

Can merge
@afc163 afc163 merged commit c5874c1 into ant-design:feature Nov 9, 2018
23 checks passed
23 checks passed
Header rules No header rules processed
Details
Pages changed 19 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 91.88%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +8.11% compared to 713b363
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@ilanus ilanus mentioned this pull request Dec 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ilanus @afc163