Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up
+32
−32
Conversation
This comment has been minimized.
This comment has been minimized.
netlify
bot
commented
Nov 10, 2018
•
|
Deploy preview for ant-design ready! Built with commit 89767f9 |
This comment has been minimized.
This comment has been minimized.
|
Lint was already broken on files I didn't touch. |
This comment has been minimized.
This comment has been minimized.
|
@OvestLabs You should pull the latest code. |
This comment has been minimized.
This comment has been minimized.
I already have the latest code... as of this message. |
OvestLabs
force-pushed the
OvestLabs:initial-sort-order
branch
from
ee7c68f
to
9ce68d5
Nov 17, 2018
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Nov 17, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #13069 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 212 212
Lines 5641 5641
Branches 1632 1632
=======================================
Hits 5206 5206
- Misses 428 430 +2
+ Partials 7 5 -2
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
@ztplz I rebased onto master. |
OvestLabs
force-pushed the
OvestLabs:initial-sort-order
branch
from
9ce68d5
to
89767f9
Nov 17, 2018
This comment has been minimized.
This comment has been minimized.
afc163
assigned
zombieJ
Nov 20, 2018
zombieJ
merged commit 2bf0fad
into
ant-design:master
Nov 20, 2018
18 checks passed
ci/circleci: compile
Your tests passed on CircleCI!
Details
ci/circleci: dist
Your tests passed on CircleCI!
Details
ci/circleci: lint
Your tests passed on CircleCI!
Details
ci/circleci: setup
Your tests passed on CircleCI!
Details
ci/circleci: test_dist
Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15
Your tests passed on CircleCI!
Details
ci/circleci: test_dom
Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15
Your tests passed on CircleCI!
Details
ci/circleci: test_es
Your tests passed on CircleCI!
Details
ci/circleci: test_es_15
Your tests passed on CircleCI!
Details
ci/circleci: test_lib
Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15
Your tests passed on CircleCI!
Details
ci/circleci: test_node
Your tests passed on CircleCI!
Details
ci/circleci: test_node_15
Your tests passed on CircleCI!
Details
codecov/patch
100% of diff hit (target 92.28%)
Details
codecov/project
92.28% (+0%) compared to 7180f6b
Details
deploy/netlify
Deploy preview ready!
Details
security/snyk - package.json (paranoidjk)
No manifest changes detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
OvestLabs commentedNov 10, 2018
When using a
Tablecomponent, the sort order is always jumping to descending on the first click. This pull request modifies this to ensure the first click is ascending.Column 1st click:
undefined=>'ascend'Column 2nd click:
'ascend'=>'descend'Column 3rd click:
'descend'=>undefined...
I have never seen table sorting that starts with descending order. So, it's fair to claim this as a standard (none => ascend => descend => none)
Note: lint was broken on master. You will find several
let=>constchanges to appease the hook.