New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting sort order with 'ascend', then 'descend', then undefined. #13069
Conversation
Deploy preview for ant-design ready! Built with commit 89767f9 |
Lint was already broken on files I didn't touch. |
@OvestLabs You should pull the latest code. |
I already have the latest code... as of this message. |
ee7c68f
to
9ce68d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #13069 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 212 212
Lines 5641 5641
Branches 1632 1632
=======================================
Hits 5206 5206
- Misses 428 430 +2
+ Partials 7 5 -2
Continue to review full report at Codecov.
|
@ztplz I rebased onto master. |
9ce68d5
to
89767f9
Compare
When using a
Table
component, the sort order is always jumping to descending on the first click. This pull request modifies this to ensure the first click is ascending.Column 1st click:
undefined
=>'ascend'
Column 2nd click:
'ascend'
=>'descend'
Column 3rd click:
'descend'
=>undefined
...
I have never seen table sorting that starts with descending order. So, it's fair to claim this as a standard (none => ascend => descend => none)
Note: lint was broken on master. You will find several
let
=>const
changes to appease the hook.