Starting sort order with 'ascend', then 'descend', then undefined. #13069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ant-design ready! Built with commit 89767f9 |
|
Lint was already broken on files I didn't touch. |
|
@OvestLabs You should pull the latest code. |
I already have the latest code... as of this message. |
OvestLabs
force-pushed
the
initial-sort-order
branch
from
ee7c68f
to
9ce68d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #13069 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 212 212
Lines 5641 5641
Branches 1632 1632
=======================================
Hits 5206 5206
- Misses 428 430 +2
+ Partials 7 5 -2
Continue to review full report at Codecov.
|
|
@ztplz I rebased onto master. |
OvestLabs
force-pushed
the
initial-sort-order
branch
from
9ce68d5
to
89767f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When using a
Tablecomponent, the sort order is always jumping to descending on the first click. This pull request modifies this to ensure the first click is ascending.Column 1st click:
undefined=>'ascend'Column 2nd click:
'ascend'=>'descend'Column 3rd click:
'descend'=>undefined...
I have never seen table sorting that starts with descending order. So, it's fair to claim this as a standard (none => ascend => descend => none)
Note: lint was broken on master. You will find several
let=>constchanges to appease the hook.