Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tabs additional css #13118

Merged
merged 11 commits into from Nov 23, 2018
Merged

add tabs additional css #13118

merged 11 commits into from Nov 23, 2018

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 13, 2018

ref: #13086

@zombieJ zombieJ requested a review from afc163 November 13, 2018 16:38
@netlify
Copy link

netlify bot commented Nov 13, 2018

Deploy preview for ant-design ready!

Built with commit a328f0b

https://deploy-preview-13118--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #13118 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #13118      +/-   ##
===========================================
+ Coverage    92.53%   92.54%   +<.01%     
===========================================
  Files          221      221              
  Lines         5747     5751       +4     
  Branches      1668     1669       +1     
===========================================
+ Hits          5318     5322       +4     
  Misses         424      424              
  Partials         5        5
Impacted Files Coverage Δ
components/tabs/TabBar.tsx 100% <100%> (ø) ⬆️
components/tabs/index.tsx 93.44% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d366886...a328f0b. Read the comment docs.

@zombieJ zombieJ changed the title [WIP] add tabs additional css add tabs additional css Nov 14, 2018
@zombieJ
Copy link
Member Author

zombieJ commented Nov 14, 2018

done. pls check.

@afc163
Copy link
Member

afc163 commented Nov 14, 2018

本地有测过各种内嵌的情况么,搞个 debug: true 的 demo 吧。

ink-bar 是不是也要加 prefix,还有左右切换的箭头。

@afc163
Copy link
Member

afc163 commented Nov 14, 2018

master 的 ci 要修一下

@afc163
Copy link
Member

afc163 commented Nov 14, 2018

oops

@zombieJ zombieJ changed the base branch from master to feature November 14, 2018 12:52
@zombieJ
Copy link
Member Author

zombieJ commented Nov 14, 2018

move to feature branch.

@@ -1,6 +1,7 @@
import * as React from 'react';
import Icon from '../icon';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolute imports should come before relative imports

@@ -12,6 +13,9 @@ export default class TabBar extends React.Component<TabsProps> {
tabBarExtraContent,
tabPosition,
prefixCls,
className,
size,
type = 'line',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract to static defaultProps ?

@zombieJ
Copy link
Member Author

zombieJ commented Nov 22, 2018

Updated. It's time to merge~

@zombieJ zombieJ merged commit 95a76b0 into feature Nov 23, 2018
@zombieJ zombieJ deleted the tabFix branch November 23, 2018 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants