/ant-design

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(switch):set disabled for loading status & set cursor as not-allowed #13219

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jojoLockLock @afc163
@jojoLockLock
Contributor

jojoLockLock commented Nov 20, 2018 •
edited

fix

can operating switch even loading status (chrome plugin vimium )
should set disabled status for loading

image

cursor should be not-allowd for disabled status

image
@netlify

This comment has been minimized.

Sign in to view

netlify bot commented Nov 20, 2018 •
edited

Deploy preview for ant-design ready!

Built with commit 0a2d52e

https://deploy-preview-13219--ant-design.netlify.com

@jojoLockLock jojoLockLock force-pushed the jojoLockLock:fix-switch branch 2 times, most recently from ca5ef19 to dd947df Nov 20, 2018

@jojoLockLock jojoLockLock force-pushed the jojoLockLock:fix-switch branch from dd947df to 0a2d52e Nov 21, 2018

@codecov

This comment has been minimized.

Sign in to view

codecov bot commented Nov 21, 2018 •
edited

Codecov Report

Merging #13219 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13219      +/-   ##
==========================================
+ Coverage   92.28%   92.28%   +<.01%     
==========================================
  Files         212      212              
  Lines        5641     5642       +1     
  Branches     1632     1622      -10     
==========================================
+ Hits         5206     5207       +1     
  Misses        428      428              
  Partials        7        7
Impacted Files Coverage Δ
components/switch/index.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf0fad...0a2d52e. Read the comment docs.

@afc163 afc163 merged commit 171e366 into ant-design:master Nov 21, 2018
18 checks passed

18 checks passed

ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.28%)
Details
codecov/project 92.28% (+<.01%) compared to 2bf0fad
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment