Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ts define #14591

Merged
merged 1 commit into from Jan 28, 2019
Merged

fix ts define #14591

merged 1 commit into from Jan 28, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 28, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

5ec4383#r32083490

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

zombieJ referenced this pull request Jan 28, 2019
Fix Menu.SubMenu props from any to real def
@netlify
Copy link

netlify bot commented Jan 28, 2019

Deploy preview for ant-design ready!

Built with commit 4ca822a

https://deploy-preview-14591--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #14591 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14591      +/-   ##
==========================================
+ Coverage   94.41%   94.43%   +0.02%     
==========================================
  Files         333      333              
  Lines        7265     7265              
  Branches     1823     1823              
==========================================
+ Hits         6859     6861       +2     
+ Misses        391      389       -2     
  Partials       15       15
Impacted Files Coverage Δ
components/menu/SubMenu.tsx 92.85% <ø> (ø) ⬆️
components/upload/UploadList.tsx 89.74% <0%> (+1.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6240871...4ca822a. Read the comment docs.

@zombieJ zombieJ merged commit 8838bd6 into master Jan 28, 2019
@zombieJ zombieJ deleted the fix-ts-def branch January 28, 2019 05:29
export interface SubMenuProps {
rootPrefixCls?: string;
className?: string;
disabled?: boolean;
title?: React.ReactNode;
onTitleClick?: (key: string, domEvent?: Event) => void;
onTitleClick?: (clickEntity: TitleClickEntity) => void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key domEvent 是需要可选吗?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是 onTitleClick 必提供的参数,用户可以不用,不是错:样例

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants