New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ts define #14591
fix ts define #14591
Conversation
Deploy preview for ant-design ready! Built with commit 4ca822a |
Codecov Report
@@ Coverage Diff @@
## master #14591 +/- ##
==========================================
+ Coverage 94.41% 94.43% +0.02%
==========================================
Files 333 333
Lines 7265 7265
Branches 1823 1823
==========================================
+ Hits 6859 6861 +2
+ Misses 391 389 -2
Partials 15 15
Continue to review full report at Codecov.
|
export interface SubMenuProps { | ||
rootPrefixCls?: string; | ||
className?: string; | ||
disabled?: boolean; | ||
title?: React.ReactNode; | ||
onTitleClick?: (key: string, domEvent?: Event) => void; | ||
onTitleClick?: (clickEntity: TitleClickEntity) => void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
key
domEvent
是需要可选吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是 onTitleClick 必提供的参数,用户可以不用,不是错:样例
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
This is a ...
What's the background?
5ec4383#r32083490
Self Check before Merge