Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SubMenu] Add onTitleMouseEnter and onTitleMouseLeave to public interface #14737

Closed

Conversation

Projects
None yet
2 participants
@GabeMedrash
Copy link
Contributor

commented Feb 6, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
    I would like to use the SubMenu component, but I need to know, programmatically, when a user is hovering a SubMenu--this allows me to capture "focus" state and respond to it.
  2. Resolve what problem.
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
    SubMenu exposes a subset of rc-menu's SubMenu interface. This PR makes public and explicit that onTitleMouseEnter and onTitleMouseLeave are allowable props to pass through to the RcSubMenu.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
    This is a non-breaking change.
  2. What will say in changelog?
    [SubMenu] expose onTitleMouseEnter and onTitleMouseLeave
  3. Does this PR contains potential break change or other risk?
    No

Changelog description (Optional if not new feature)

  1. English description
    [SubMenu] expose onTitleMouseEnter and onTitleMouseLeave
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@netlify

This comment has been minimized.

Copy link

commented Feb 6, 2019

Deploy preview for ant-design ready!

Built with commit 59453f9

https://deploy-preview-14737--ant-design.netlify.com

@GabeMedrash

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

This is quite literally a non-breaking Typescript definitions change. I don't have the slightest idea how it could possibly impact the tests that show as broken on CI. Is the feature branch the correct branch to be submitting a PR against?

@yesmeck

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

@GabeMedrash Fixes should be PR to master

@yesmeck

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

Merged in 6dce9af

@yesmeck yesmeck closed this Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.