Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: add onClick to AbstractCheckboxProps #14762

Merged
merged 1 commit into from Feb 10, 2019

Conversation

Projects
None yet
2 participants
@Frezc
Copy link
Contributor

commented Feb 9, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

I need to stop propagation of click event and found it supported but not typed.

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

commented Feb 9, 2019

Deploy preview for ant-design ready!

Built with commit 0512aea

https://deploy-preview-14762--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Feb 9, 2019

Codecov Report

Merging #14762 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14762      +/-   ##
==========================================
- Coverage   92.74%    92.7%   -0.05%     
==========================================
  Files         236      236              
  Lines        6220     6220              
  Branches     1852     1835      -17     
==========================================
- Hits         5769     5766       -3     
- Misses        448      453       +5     
+ Partials        3        1       -2
Impacted Files Coverage Δ
components/checkbox/Checkbox.tsx 100% <ø> (ø) ⬆️
components/_util/wave.tsx 84.61% <0%> (-2.89%) ⬇️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/time-picker/index.tsx 82.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dee5c5...0512aea. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Feb 9, 2019

Codecov Report

Merging #14762 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14762      +/-   ##
==========================================
- Coverage   92.74%    92.7%   -0.05%     
==========================================
  Files         236      236              
  Lines        6220     6220              
  Branches     1852     1835      -17     
==========================================
- Hits         5769     5766       -3     
- Misses        448      453       +5     
+ Partials        3        1       -2
Impacted Files Coverage Δ
components/checkbox/Checkbox.tsx 100% <ø> (ø) ⬆️
components/_util/wave.tsx 84.61% <0%> (-2.89%) ⬇️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/time-picker/index.tsx 82.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dee5c5...0512aea. Read the comment docs.

@afc163 afc163 merged commit 6c25980 into ant-design:master Feb 10, 2019

26 of 28 checks passed

Header rules No header rules processed
Details
Pages changed 124 new files uploaded
Details
AccessLint Review complete
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No alert changes
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 2dee5c5...0512aea
Details
codecov/project 92.7% (-0.05%) compared to 2dee5c5
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.