Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Progress shows the success status incorrectly #14769

Merged
merged 1 commit into from Feb 10, 2019

Conversation

Projects
None yet
2 participants
@imhele
Copy link
Contributor

commented Feb 10, 2019

fix: Progress shows the success status while successPercent={0} and percent={100}

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.

Progress shouldn't show success status when successPercent is 0.

<Progress percent={100} successPercent={0} />

But now I can only do that like this:

<Progress percent={100} successPercent="0" />

https://codepen.io/anon/pen/KJoarW?editors=0010

  1. Resolve what problem.
  2. Related issue link.

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

commented Feb 10, 2019

Deploy preview for ant-design ready!

Built with commit 6f15f63

https://deploy-preview-14769--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Feb 10, 2019

Codecov Report

Merging #14769 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14769      +/-   ##
==========================================
+ Coverage    92.7%   92.74%   +0.04%     
==========================================
  Files         236      236              
  Lines        6220     6220              
  Branches     1835     1852      +17     
==========================================
+ Hits         5766     5769       +3     
+ Misses        453      448       -5     
- Partials        1        3       +2
Impacted Files Coverage Δ
components/progress/progress.tsx 91.66% <100%> (ø) ⬆️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/time-picker/index.tsx 82.85% <0%> (ø) ⬆️
components/_util/wave.tsx 87.5% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ebf5a0...6f15f63. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Feb 10, 2019

Codecov Report

Merging #14769 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14769      +/-   ##
==========================================
+ Coverage    92.7%   92.74%   +0.04%     
==========================================
  Files         236      236              
  Lines        6220     6220              
  Branches     1835     1852      +17     
==========================================
+ Hits         5766     5769       +3     
+ Misses        453      448       -5     
- Partials        1        3       +2
Impacted Files Coverage Δ
components/progress/progress.tsx 91.66% <100%> (ø) ⬆️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/time-picker/index.tsx 82.85% <0%> (ø) ⬆️
components/_util/wave.tsx 87.5% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ebf5a0...6f15f63. Read the comment docs.

@zombieJ zombieJ merged commit 3c4a731 into ant-design:master Feb 10, 2019

26 of 28 checks passed

Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
AccessLint Review complete
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No alert changes
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.7%)
Details
codecov/project 92.74% (+0.04%) compared to 7ebf5a0
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

ruoqianfengshao added a commit to ruoqianfengshao/ant-design that referenced this pull request Feb 13, 2019

@imhele imhele deleted the imhele:fix-Progress branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.