Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Countdown support `onFinish` #14791

Merged
merged 4 commits into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@zombieJ
Copy link
Member

commented Feb 12, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

close #14627

API Realization (Optional if not new feature)

function onFinish() {
  console.log('finished!');
}

<Countdown {...restProps} onFinish={onFinish} />

What's the effect? (Optional if not new feature)

No effects

Changelog description (Optional if not new feature)

  1. Statistic.Countdown support onFinish prop.
  2. Statistic.Countdown 支持 onFinish 属性。

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

commented Feb 12, 2019

Deploy preview for ant-design ready!

Built with commit 1603b4c

https://deploy-preview-14791--ant-design.netlify.com

@ztplz

This comment has been minimized.

Copy link
Collaborator

commented Feb 12, 2019

我那个关了 你这边改一下

@codecov

This comment has been minimized.

Copy link

commented Feb 12, 2019

Codecov Report

Merging #14791 into feature will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #14791      +/-   ##
===========================================
+ Coverage    92.73%   92.79%   +0.05%     
===========================================
  Files          236      236              
  Lines         6224     6231       +7     
  Branches      1836     1866      +30     
===========================================
+ Hits          5772     5782      +10     
+ Misses         451      446       -5     
- Partials         1        3       +2
Impacted Files Coverage Δ
components/statistic/Countdown.tsx 100% <100%> (+3.7%) ⬆️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/time-picker/index.tsx 81.94% <0%> (ø) ⬆️
components/upload/UploadList.tsx 88.99% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f2bbe7...1603b4c. Read the comment docs.

@zombieJ zombieJ requested review from afc163 and ztplz Feb 12, 2019

@zombieJ zombieJ merged commit 5ad9469 into feature Feb 12, 2019

25 of 27 checks passed

Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
AccessLint Review complete
LGTM analysis: JavaScript No alert changes
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.73%)
Details
codecov/project 92.79% (+0.05%) compared to 8f2bbe7
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@zombieJ zombieJ deleted the onFinish branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.