Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(time-picker): fix icon style #14861

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
2 participants
@Yangzhedi
Copy link
Contributor

commented Feb 15, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

fix#14841

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.
image
image

@codecov

This comment has been minimized.

Copy link

commented Feb 15, 2019

Codecov Report

Merging #14861 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14861      +/-   ##
==========================================
+ Coverage   92.75%    92.8%   +0.04%     
==========================================
  Files         236      236              
  Lines        6226     6226              
  Branches     1864     1836      -28     
==========================================
+ Hits         5775     5778       +3     
+ Misses        448      447       -1     
+ Partials        3        1       -2
Impacted Files Coverage Δ
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/time-picker/index.tsx 82.85% <0%> (ø) ⬆️
components/_util/wave.tsx 87.5% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dce9af...174c296. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Feb 15, 2019

Codecov Report

Merging #14861 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14861      +/-   ##
==========================================
+ Coverage   92.75%    92.8%   +0.04%     
==========================================
  Files         236      236              
  Lines        6226     6226              
  Branches     1864     1836      -28     
==========================================
+ Hits         5775     5778       +3     
+ Misses        448      447       -1     
+ Partials        3        1       -2
Impacted Files Coverage Δ
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/time-picker/index.tsx 82.85% <0%> (ø) ⬆️
components/_util/wave.tsx 87.5% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dce9af...174c296. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Feb 15, 2019

Deploy preview for ant-design ready!

Built with commit 174c296

https://deploy-preview-14861--ant-design.netlify.com

@afc163 afc163 merged commit 2f81d00 into ant-design:master Feb 15, 2019

25 of 28 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Header rules No header rules processed
Details
Pages changed 30 new files uploaded
Details
AccessLint Review complete
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No code changes detected
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6dce9af...174c296
Details
codecov/project 92.8% (+0.04%) compared to 6dce9af
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.