Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: add "onClick" and "className" types for Step #14903

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
None yet
2 participants
@ilanus
Copy link
Collaborator

commented Feb 18, 2019

#14896

@ilanus ilanus changed the title Fix: missing types for Step Types: add "onClick" and "className" types for Step Feb 18, 2019

@ztplz

ztplz approved these changes Feb 18, 2019

@netlify

This comment has been minimized.

Copy link

commented Feb 18, 2019

Deploy preview for ant-design ready!

Built with commit 8eddf15

https://deploy-preview-14903--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Feb 18, 2019

Codecov Report

Merging #14903 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14903      +/-   ##
==========================================
- Coverage   92.77%   92.74%   -0.04%     
==========================================
  Files         236      236              
  Lines        6230     6230              
  Branches     1862     1862              
==========================================
- Hits         5780     5778       -2     
- Misses        447      449       +2     
  Partials        3        3
Impacted Files Coverage Δ
components/steps/index.tsx 100% <ø> (ø) ⬆️
components/upload/UploadList.tsx 87.15% <0%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6678c6a...8eddf15. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Feb 18, 2019

Codecov Report

Merging #14903 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14903      +/-   ##
==========================================
- Coverage   92.77%   92.74%   -0.04%     
==========================================
  Files         236      236              
  Lines        6230     6230              
  Branches     1862     1862              
==========================================
- Hits         5780     5778       -2     
- Misses        447      449       +2     
  Partials        3        3
Impacted Files Coverage Δ
components/steps/index.tsx 100% <ø> (ø) ⬆️
components/upload/UploadList.tsx 87.15% <0%> (-1.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6678c6a...8eddf15. Read the comment docs.

@ilanus ilanus merged commit b54f367 into ant-design:master Feb 18, 2019

26 of 28 checks passed

Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
AccessLint Review complete
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6678c6a...8eddf15
Details
codecov/project 92.74% (-0.04%) compared to 6678c6a
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.