Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust input style #14912

Merged
merged 2 commits into from Feb 19, 2019
Merged

adjust input style #14912

merged 2 commits into from Feb 19, 2019

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 19, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

fix #14900

What's the effect? (Optional if not new feature)

May affect some user style if they set text-align at parent element.

Changelog description (Optional if not new feature)

  1. Adjust Input style to support text-align: inherit.
  2. 调整 Input 样式以支持 text-align: inherit

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@zombieJ zombieJ requested a review from afc163 Feb 19, 2019
@@ -50,6 +50,7 @@
color: @input-color;
font-size: @font-size-base;
line-height: @line-height-base;
text-align: inherit;
Copy link
Member

@afc163 afc163 Feb 19, 2019

直接改这个会不会不太好,只修改内部的 wrapper 内的 input 吧。

Copy link
Member Author

@zombieJ zombieJ Feb 19, 2019

done. Pls check.

@codecov
Copy link

@codecov codecov bot commented Feb 19, 2019

Codecov Report

Merging #14912 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14912   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files         236      236           
  Lines        6230     6230           
  Branches     1862     1864    +2     
=======================================
  Hits         5778     5778           
  Misses        449      449           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54f367...dd10d14. Read the comment docs.

@netlify
Copy link

@netlify netlify bot commented Feb 19, 2019

Deploy preview for ant-design ready!

Built with commit dd10d14

https://deploy-preview-14912--ant-design.netlify.com

@afc163 afc163 merged commit eddfbd5 into master Feb 19, 2019
29 checks passed
@afc163 afc163 deleted the input-text-align-inherit branch Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants