Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to remove FormItem explain-holder #14937

Merged
merged 2 commits into from Feb 19, 2019

Conversation

Projects
None yet
3 participants
@zombieJ
Copy link
Member

commented Feb 19, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

fix #14909

Changelog description (Optional if not new feature)

  1. Revert FormItem with additional place holder.
  2. 回滚 FormItem 额外占位符占据位置的问题。

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

zombieJ added some commits Feb 19, 2019

Revert "sync form item (#14778)"
This reverts commit 5ac674e.
@codecov

This comment has been minimized.

Copy link

commented Feb 19, 2019

Codecov Report

Merging #14937 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14937      +/-   ##
==========================================
- Coverage   92.78%   92.74%   -0.04%     
==========================================
  Files         236      236              
  Lines        6235     6230       -5     
  Branches     1865     1834      -31     
==========================================
- Hits         5785     5778       -7     
- Misses        447      451       +4     
+ Partials        3        1       -2
Impacted Files Coverage Δ
components/form/FormItem.tsx 96.36% <ø> (-0.11%) ⬇️
components/upload/UploadList.tsx 87.15% <0%> (-1.84%) ⬇️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/time-picker/index.tsx 82.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1552955...8ef99fb. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Feb 19, 2019

Deploy preview for ant-design ready!

Built with commit 8ef99fb

https://deploy-preview-14937--ant-design.netlify.com

@ztplz

ztplz approved these changes Feb 19, 2019

@afc163

afc163 approved these changes Feb 19, 2019

@zombieJ zombieJ merged commit c29323b into master Feb 19, 2019

25 of 29 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
License Compliance FOSSA is analyzing this commit
Details
Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
AccessLint Review complete
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 1552955...8ef99fb
Details
codecov/project 92.74% (-0.04%) compared to 1552955
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@zombieJ zombieJ deleted the revert-form branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.