Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rc-input-number@4.4.0 to fix #13896 #14960

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
2 participants
@afc163
Copy link
Member

commented Feb 20, 2019

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

#13896

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

<InputNumber defaultValue="1" onChange={onChange} />

When we delete existed value in input, then blur it. The onChange will return null instead of original undefined now, according to discussion in #13896

Changelog description (Optional if not new feature)

  • 🐛 修正 InputNumber onChange 返回 undefinednull,以避免控件的值无法正确收集清空的问题。#13896

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@afc163 afc163 changed the title :up: Upgrade rc-input-number@4.4.0 to fix 13896 Upgrade rc-input-number@4.4.0 to fix 13896 Feb 20, 2019

@afc163 afc163 referenced this pull request Feb 20, 2019

Closed

InputNumber组件undefined的问题 #13896

0 of 1 task complete
@codecov

This comment has been minimized.

Copy link

commented Feb 20, 2019

Codecov Report

Merging #14960 into feature will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #14960      +/-   ##
===========================================
- Coverage    93.04%   93.01%   -0.04%     
===========================================
  Files          246      246              
  Lines         6601     6601              
  Branches      1944     1946       +2     
===========================================
- Hits          6142     6140       -2     
- Misses         456      458       +2     
  Partials         3        3
Impacted Files Coverage Δ
components/back-top/index.tsx 88.7% <0%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8389b94...a178552. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Feb 20, 2019

Deploy preview for ant-design ready!

Built with commit a178552

https://deploy-preview-14960--ant-design.netlify.com

@afc163 afc163 changed the title Upgrade rc-input-number@4.4.0 to fix 13896 Upgrade rc-input-number@4.4.0 to fix #13896 Feb 20, 2019

@afc163 afc163 merged commit 7bbeaff into feature Feb 21, 2019

26 of 28 checks passed

Header rules No header rules processed
Details
Pages changed 13 new files uploaded
Details
AccessLint Review complete
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 8389b94...a178552
Details
codecov/project 93.01% (-0.04%) compared to 8389b94
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@afc163 afc163 deleted the upgrade-input-number branch Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.